Chrome 126 validates GPUQueue.submit() command buffer uniqueness #24881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
3 tasks
caugner
reviewed
Oct 30, 2024
| "support": { | ||
| "chrome": { | ||
| "version_added": "126", | ||
| "notes": "Currently supported on ChromeOS, macOS, and Windows only." |
There was a problem hiding this comment.
Nit: It might be nice to explicitly mention the platforms where the feature is not available, but given that there are already 405 notes like this across the GPU features, this is probably not the right place to start this.
Co-authored-by: Claas Augner <[email protected]>
caugner
approved these changes
Nov 4, 2024
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Chrome 126, the behavior of the
GPUQueue.submit()method has been updated to be correct as per spec — the referenced command buffers must be unique.This PR adds a data point for this update.
See https://developer.chrome.com/blog/new-in-webgpu-126#submitted_command_buffers_must_be_unique for the information source.
Test results and supporting details
Related issues
project issue: mdn/content#36344